Azure / Azure/azure-rest-api-specs
[BUG] Security subAssessments.json 2019-01-01-preview misses assessedResourceType that exists in runtime
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 6k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 444
Description
### API Spec link
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json
### API Spec version
2019-01-01-preview
### Describe the bug
Swagger only defines 3 types of "AdditionalData"
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json#L254-L258
But runtime has more, e.g. `AzureContainerRegistryVulnerability`.
See https://github.com/Azure/azure-sdk-for-java/issues/35478#issuecomment-1935248271
### Expected behavior
Swagger defines schema for all types of "AdditionalData"
### Actual behavior
Swagger misses these schemas.
### Reproduction Steps
Call `/providers/Microsoft.Security/subAssessments` API when your subscription has some "subAssessment"s.
My test is `"x-ms-client-request-id":"f76fbf6f-e6e6-403d-a9ee-20b2cefbe7b2"`
### Environment
_No response_
Contributor guide
Research direction
Start with specification/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/subAssessments.json, especially the AdditionalData definitions at lines 254-258, and compare them with responses from /providers/Microsoft.Security/subAssessments. Identify the runtime assessedResourceType values, including AzureContainerRegistryVulnerability, and update the specification so each has a schema.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- openapi
- Domain
- api, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100