Azure / Azure/azure-rest-api-specs

Azure Search Expand WaterMark Support

Open
#25,418 0 comments 0 reactions 0 assignees View on GitHub
customer-reported question Service Attention
Dominant language
TypeSpec
Stars
3.1k
Forks
6k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

Is your feature request related to a problem? Please describe.
I am trying to build an indexer in Azure Search which utilizes the parameters configuration settings convertHighWaterMarkToRowVersion and disableOrderByHighWaterMarkColumn. The current IndexingParametersConfiguration class excludes these two settings, and passing a dictionary containing these settings directly ignores them when making a request to the API.

The functionality of these parameters is described [in the Azure Search documentation](https://learn.microsoft.com/en-us/azure/search/search-howto-connecting-azure-sql-database-to-azure-search-using-indexers#configure-and-run-the-azure-sql-indexer)

Describe the solution you'd like
Add these two fields to the class IndexingParametersConfiguration in file azure\search\documents\indexes_generated\models_models_py3.py among other relevant declarations. Documentation indicates these fields are auto-generated by this repository.

Describe alternatives you've considered
I intended to put in a pull request myself, however, the files in question are code-generated, so any changes I make would be overwritten. The documentation only points to the [Rest API Specs](https://github.com/Azure/azure-rest-api-specs/tree/main/specification/search) but does not seem to include information related to the data model.

Additional context
N/A

Contributor guide

Open the contributing guide

Research direction

Start by reading the Azure Search REST API Specs and tracing how they generate azure/search/documents/indexes_generated/models_models_py3.py, focusing on IndexingParametersConfiguration. Confirm where the two documented indexer settings belong and verify that generated requests preserve both fields when the model is used.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure
Domain
cloud, search
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.