Azure / Azure/azure-rest-api-specs
HDInsight/cluster incorrectly marked secret properties
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 444
Description
We(Azure Service Operator) have an [ask to support HDInsight/Cluster](https://github.com/Azure/azure-service-operator/issues/2768) as an ASO resource. However, I noticed a few below properties that are marked as `x-ms-secret` in the HDInsight/clusters spec which maybe are incorrectly marked as secrets.
[Configurations](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2023-04-15-preview/cluster.json#L772) - An empty object
[ScriptActions](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2023-04-15-preview/cluster.json#L1134) - An array of object
[MinInstanceCount](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2023-04-15-preview/cluster.json#L1083) - An int
[SshProfile](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2023-04-15-preview/cluster.json#L1062) - An object
Contributor guide
Research direction
Inspect specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2023-04-15-preview/cluster.json at the linked Configurations, MinInstanceCount, SshProfile, and ScriptActions lines, and compare their x-ms-secret markings with the surrounding schema. Confirm which annotations are incorrect and run the repository's specification validation checks; done means the secret markings accurately reflect these properties.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- openapi
- Domain
- api, cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100