Azure / Azure/azure-rest-api-specs

In a PATCH operation supportsHttpsTrafficOnly property for StorageAccountPropertiesUpdateParameters should not have a default value

Open
#2,287 3 comments 2 reactions 0 assignees View on GitHub
KeyVault Service Attention
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
3d 2h
Merged PRs (30d)
424

Description

request body for PATCH operation MUST not have default values for properties.
Please refer to the node sdk issue filed by a customer https://github.com/Azure/azure-sdk-for-node/issues/2390#issuecomment-358713353.

Specs with api-version 2016-12-01, 2017-06-01 and 2017-10-01 need to be corrected as this will affect sdks with multi api version support.
Folks from the service team:
@bluww @JasonYang-MSFT

Folks from SDK Team: FYI
@shahabhijeet @sarangan12 @marstr @lmazuel @jianghaolu.

NOTE: If your SDK supports not setting default values in request body of a PATCH operation then you are fine.

Contributor guide

Open the contributing guide

Research direction

Locate the StorageAccountPropertiesUpdateParameters definitions for API versions 2016-12-01, 2017-06-01, and 2017-10-01 in the REST specifications, then inspect the PATCH request schemas for supportsHttpsTrafficOnly. Done means those PATCH schemas no longer assign a default value to that property in all three versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.