Azure / Azure/azure-rest-api-specs

[Bug][Azure Firewall] Azure Firewall "additionalProperties" does not properly allow null values

Open
#21,181 4 comments 0 reactions 0 assignees View on GitHub
Network - Firewall Service Attention
Dominant language
TypeSpec
Stars
3.1k
Forks
6k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

additional properties should be "key": string? (optional string)

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/network/resource-manager/Microsoft.Network/stable/2022-05-01/azureFirewall.json#L620

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/network/resource-manager/Microsoft.Network/stable/2022-05-01/azureFirewall.json#L686

This prevents different sdks/cli/powershell from properly validating a value client side.

Contributor guide

Open the contributing guide

Research direction

Open specification/network/resource-manager/Microsoft.Network/stable/2022-05-01/azureFirewall.json at the referenced lines 620 and 686 and inspect the Azure Firewall additional-properties definitions. Update the schema so the optional string value accepts null, then validate the specification using the repository's available checks; done means client SDK, CLI, and PowerShell validation can accept null.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
api, cloud
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.