Azure / Azure/azure-rest-api-specs
ResourceGuards.Patch API should be able to update vaultCriticalOperationExclusionList
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 444
Description
The request payload of [ResourceGuards.PUT API](https://github.com/Azure/azure-rest-api-specs/blob/aa42d66d5b919ea80c8dde04ae19d30a9c974d7d/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json#L2511) includes "[vaultCriticalOperationExclusionList](https://github.com/Azure/azure-rest-api-specs/blob/aa42d66d5b919ea80c8dde04ae19d30a9c974d7d/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json#L6380)" but it doesn't include "[monitoringSettings](https://github.com/Azure/azure-rest-api-specs/blob/aa42d66d5b919ea80c8dde04ae19d30a9c974d7d/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json#L5481)".
However, the request payload of [ResourceGuards.Patch API](https://github.com/Azure/azure-rest-api-specs/blob/aa42d66d5b919ea80c8dde04ae19d30a9c974d7d/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json#L2664) includes "[monitoringSettings](https://github.com/Azure/azure-rest-api-specs/blob/aa42d66d5b919ea80c8dde04ae19d30a9c974d7d/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json#L5481)" but it doesn't include "[vaultCriticalOperationExclusionList](https://github.com/Azure/azure-rest-api-specs/blob/aa42d66d5b919ea80c8dde04ae19d30a9c974d7d/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json#L6380)".
These two request payloads for ResourceGuards are different. Per my understanding, they should be same and ResourceGuards.Patch API should support to update "vaultCriticalOperationExclusionList" instead of "monitoringSettings". So could you help have a look this issue? Thanks .
Contributor guide
Research direction
Open specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2022-04-01/dataprotection.json at the ResourceGuards PUT and Patch definitions around lines 2511 and 2664, then compare the properties linked at lines 5481 and 6380. Done means the Patch request supports vaultCriticalOperationExclusionList instead of monitoringSettings, with the specification remaining valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, json, openapi
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100