Azure / Azure/azure-rest-api-specs
[AppService] containerApps_ListSecrets operation probably miss a resourceGroup in the path
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 3d 37m
- Merged PRs (30d)
- 446
Description
From the swagger [reference here](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/web/resource-manager/Microsoft.Web/stable/2021-03-01/ContainerApps.json#L258), it doesn't need a resourceGroupName parameter at all, but according to this issue https://github.com/Azure/azure-sdk-for-js/issues/20042 reported from our JS SDK customer, it actually need a resourceGroupName parameter
From the containerApp resource related operations [here](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/web/resource-manager/Microsoft.Web/stable/2021-03-01/ContainerApps.json#L99), it indeed has an resourceGroup here.
We proably need to change the path of listSecrets operation from
```
"/subscriptions/{subscriptionId}/providers/Microsoft.Web/containerApps/{name}/listSecrets"
```
to
```
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/containerApps/{name}/listSecrets"
```
But as the issue https://github.com/Azure/azure-sdk-for-js/issues/20042 mentioned, even if we tried to change it this way in our local and regenerate the JS SDK, we still can't get the expected response. Guess there're also some fixes needed in their service backend.
Contributor guide
Research direction
Review specification/web/resource-manager/Microsoft.Web/stable/2021-03-01/ContainerApps.json around the containerApps_ListSecrets operation at line 258 and compare it with the container app resource path around line 99. Check the related Azure SDK for JavaScript issue 20042 and validate whether the path change and any service-backend fix produce the expected response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure
- Domain
- api, cloud
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100