Azure / Azure/azure-rest-api-specs
Rename some AnomalyDetector API
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 3d 37m
- Merged PRs (30d)
- 446
Description
Comments on APIView:
- https://apiview.dev/Assemblies/Review/dc9fff263c5f4c54a06172f1cbe4a879?diffOnly=True&diffRevisionId=9d4c22fd01a54ee89c9943c62a8b551f
- https://apiview.dev/Assemblies/Review/a16dffedf37b4186afb370c573bd076e?diffOnly=True&diffRevisionId=7d1586289dc3429e8d4062a6f25a6bd7
- https://apiview.dev/Assemblies/Review/2ae79204a53448e1a94c8bf0512bbd02/596152e4575b4d07a18c34a8716c5826?diffRevisionId=84452fdf01024d469338a3a4b2026686&doc=False&diffOnly=False
- https://apiview.dev/Assemblies/Review/a6c6709850e34285823d7bc081f24f56?diffOnly=True&diffRevisionId=95310f66b4a245e2b5e15479eb8692f5
Some interesting points:
- This release renamed a bunch of parameters to “body”. First, we try to avoid HTTP language, and second this is a breaking change that seems unnecessary. Could you rename them back to their previous name? (For instance: body -> detectionRequest, etc.)
- The method name “lastDetectAnomaly” seems unclear in intent. Anna suggested “lastDetectedAnomaly” maybe? Some clarity around what this method is doing would help find a better name
Contributor guide
Assessment
This issue has not been assessed yet.