Azure / Azure/azure-rest-api-specs
ServiceBusRules must belong to Rules
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 3d 37m
- Merged PRs (30d)
- 446
Description
Hello Azure colleagues!
I found an issue in the: specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/Rules.json
It must belong to Rules and not Subscriptions
As OpenApiGenerator is using the tags to group the APIs it will result in putting this unique method in the SubscriptionApi instead of the RuleApi.
Here is an example of fix:
https://github.com/speedfl/azure-rest-api-specs/pull/1/files
However I don't have the vision of the impact. I let you see.
Have a good day
Contributor guide
Research direction
Start with specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/Rules.json and inspect the ServiceBusRules tags and parent resource relationship. Compare the proposed change in the linked example, then verify that OpenApiGenerator groups the method under RuleApi rather than SubscriptionApi and check for any affected generated API groupings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- openapi
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100