Azure / Azure/azure-rest-api-specs

`Microsoft.Authorization/accessReviewScheduleDefinitions` PUT body is not RPC-compliant

Open
#16,217 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Authorization Service Attention
Dominant language
TypeSpec
Stars
3.1k
Forks
6k
Avg merge
2d 21h
Merged PRs (30d)
432

Description

In the PUT definition, the API accepts the "properties" portion of the resource body directly:

https://github.com/Azure/azure-rest-api-specs/blob/88e7838a09868a51de3894114355c75929847a46/specification/authorization/resource-manager/Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L215

I suspect this is just an authoring error, and that AccessReviewScheduleDefinition should be used here instead of AccessReviewScheduleDefinitionProperties.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open specification/authorization/resource-manager/Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json at line 215 and inspect the PUT request body schema. Compare the referenced AccessReviewScheduleDefinitionProperties shape with AccessReviewScheduleDefinition, then validate the specification; done means the PUT body uses the RPC-compliant resource definition.

Written by the indexing model from the issue text.

Assessment

Tech stack
json, openapi
Domain
api, backend-api-design
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.