Azure / Azure/azure-rest-api-specs

`Microsoft.MachineLearningServices/workspaces/datastores` PUT body is not RPC-compliant

Open
#16,216 1 comment 0 reactions 0 assignees View on GitHub
Machine Learning Service Attention
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

The PUT request body for this resource type uses `DatastoreCreateRequest`, which is not compliant as per the ARM RPC: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource

https://github.com/Azure/azure-rest-api-specs/blob/88e7838a09868a51de3894114355c75929847a46/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json#L1992

Should these properties be inside "properties" as part of a resource body definition?

Note - the same issue may exist for other resources defined in this spec.

Contributor guide

Open the contributing guide

Research direction

Start with the PUT resource definition around line 1992 of specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2020-05-01-preview/machineLearningServices.json and compare it with the ARM RPC PUT resource reference. Check whether the same body shape occurs in other resources in this specification; done means the affected definitions follow the required properties wrapper.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.