Azure / Azure/azure-rest-api-specs

Microsoft.OperationalInsights/workspaces/savedSearches resource contains `etag` property defined in the wrong place

Open
#16,133 0 comments 0 reactions 0 assignees View on GitHub
Monitor - Operational Insights Service Attention
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

Reported in this comment: https://github.com/Azure/bicep/issues/784#issuecomment-923971156

Microsoft.OperationalInsights/workspaces/savedSearches has the "etag" property defined as a top-level resource property:
```json
{
"name": "mySearch",
"type": "Microsoft.OperationalInsights/workspaces/savedSearches",
"etag": "*",
"properties": {
}
}
```

It appears this in fact should be declared inside the "properties" body of this resource type:
```json
{
"name": "mySearch",
"type": "Microsoft.OperationalInsights/workspaces/savedSearches",
"properties": {
"etag": "*"
}
}
```

Here's where this is declared in the RP swagger:

https://github.com/Azure/azure-rest-api-specs/blob/88e7838a09868a51de3894114355c75929847a46/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/SavedSearches.json#L267-L270

Contributor guide

Open the contributing guide

Research direction

Start with specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/SavedSearches.json around lines 267-270 and compare the etag declaration with the issue's examples. Move the declaration to the location indicated by the RP swagger, then run the repository's applicable specification validation; done means the resource schema places etag under properties.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.