Azure / Azure/azure-rest-api-specs

Should Microsoft.ServiceFabricManagedClusters folder be Microsoft.ServiceFabric?

Open
#15,867 1 comment 0 reactions 0 assignees View on GitHub
customer-reported question Service Attention Service Fabric
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

As described in https://github.com/Azure/azure-rest-api-specs#directory-structure, this repo is fairly consistent about the folder structure. In particular, item (4) is a resource provider name. For service fabric managed clusters, the resource provider is still called `Microsoft.ServiceFabric` ([example](https://github.com/Azure/azure-rest-api-specs/blob/9816073fe0652b346f5bf328a7ba017efcb7e826/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabricManagedClusters/stable/2021-05-01/managedcluster.json#L37)) while the folder is called `Microsoft.ServiceFabricManagedClusters`: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabricManagedClusters

Shall it be renamed to `Microsoft.ServiceFabric`?

This triggered an error in [Pulumi Azure Native provider](https://github.com/pulumi/pulumi-azure-native/).

Contributor guide

Open the contributing guide

Research direction

Start with the directory-structure guidance and compare specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabricManagedClusters with managedcluster.json, especially its resource-provider reference. Check for references to the existing folder name before deciding whether the directory should use Microsoft.ServiceFabric. Done means the folder naming is consistent and the related specification links or checks still resolve.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.