Azure / Azure/azure-rest-api-specs

Microsoft.Web/certificates: tags field does not get updated / returned

Open
#14,529 9 comments 8 reactions 0 assignees View on GitHub
question Service Attention Web Apps
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
3d 2h
Merged PRs (30d)
424

Description

API Version: 2020-06-01 (Tested also on 2020-12-01)

As per the specification on

* https://docs.microsoft.com/en-us/rest/api/appservice/certificates/createorupdate
* https://docs.microsoft.com/en-us/rest/api/appservice/certificates/get

it should be possible to define `tags` field, but that has no effect.

also, in the response it seems there is a `properties.tags` field, which is always null and not documented.

I'm not sure if tags for appservice certificates is possible as i don't see it an option for it in azure portal and no definition for it in the API

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2020-12-01/Certificates.json

```
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: [DEBUG] AzureRM Request:
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: PUT /subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com?api-version=2020-06-01 HTTP/1.1
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: Host: management.azure.com
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: User-Agent: Go/go1.16.2 (amd64-darwin) go-autorest/v14.2.1 Azure-SDK-For-Go/v54.2.0 web/2020-06-01 HashiCorp Terraform/0.15.3 (+https://www.terraform.io) Terraform Plugin SDK/1.17.2 terraform-provider-azurerm/dev pid-222c6c49-1b0a-5959-a213-6608f9eb8820
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: Content-Length: 351
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: Content-Type: application/json; charset=utf-8
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Correlation-Request-Id: 7f893967-58b3-5b58-8bfc-9cd8c387b7f7
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm: Accept-Encoding: gzip
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm:
2021-05-24T16:22:00.754+0200 [DEBUG] provider.terraform-provider-azurerm:
{
"location":"westus",
"properties":{
"canonicalName":"zone4230276816.azure.allomani.com",
"password":"",
"serverFarmId":"/subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/serverfarms/acctestASP-4230276816"
},
"tags":{
"custom_tag_1":"custom tag value 1",
"custom_tag_2":"custom tag value 2"
}
}
2021-05-24T16:22:03.972+0200 [TRACE] dag/walk: vertex "provider[\"registry.terraform.io/hashicorp/azurerm\"] (close)" is waiting for "azurerm_app_service_managed_certificate.test"
2021-05-24T16:22:03.972+0200 [TRACE] dag/walk: vertex "root" is waiting for "meta.count-boundary (EachMode fixup)"
2021-05-24T16:22:03.972+0200 [TRACE] dag/walk: vertex "meta.count-boundary (EachMode fixup)" is waiting for "azurerm_app_service_managed_certificate.test"
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: [DEBUG] AzureRM Response for https://management.azure.com/subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com?api-version=2020-06-01:
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: HTTP/2.0 200 OK
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Cache-Control: no-cache
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Content-Type: application/json
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Date: Mon, 24 May 2021 14:22:06 GMT
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Expires: -1
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Pragma: no-cache
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Server: Microsoft-IIS/10.0
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Strict-Transport-Security: max-age=31536000; includeSubDomains
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: Vary: Accept-Encoding
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Aspnet-Version: 4.0.30319
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Content-Type-Options: nosniff
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Correlation-Request-Id: 7f893967-58b3-5b58-8bfc-9cd8c387b7f7
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Ratelimit-Remaining-Subscription-Writes: 1196
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Request-Id: a6d804bf-c2e4-499b-a84d-fcc57a3a0c4b
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Routing-Request-Id: GERMANYWESTCENTRAL:20210524T142206Z:e5424fd8-1cbb-43b5-ad53-4ba75955343f
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: X-Powered-By: ASP.NET
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm:
2021-05-24T16:22:06.648+0200 [DEBUG] provider.terraform-provider-azurerm: {
"id":"/subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com",
"name":"zone4230276816.azure.allomani.com",
"type":"Microsoft.Web/certificates",
"location":"West US",
"properties":{
"friendlyName":"",
"subjectName":"zone4230276816.azure.allomani.com",
"hostNames":["zone4230276816.azure.allomani.com"],
"pfxBlob":null,
"siteName":null,
"selfLink":null,
"issuer":"GeoTrust TLS DV RSA Mixed SHA256 2020 CA-1",
"issueDate":"2021-05-24T00:00:00+00:00",
"expirationDate":"2021-11-23T23:59:59+00:00",
"password":null,
"thumbprint":"E2E41BCFCD52F20E910D355190F36252B3628ED5",
"valid":null,"toDelete":null,
"cerBlob":null,
"publicKeyHash":null,
"hostingEnvironment":null,
"hostingEnvironmentProfile":null,
"keyVaultId":"","keyVaultSecretName":"",
"keyVaultSecretStatus":"Initialized",
"webSpace":"acctestRG-asmc-4230276816-WestUSwebspace-Linux",
"serverFarmId":null,
"canonicalName":"zone4230276816.azure.allomani.com",
"tags":null,
"resourceGroup":"acctestrg-asmc-4230276816"
}
}
```

```
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm: [DEBUG] AzureRM Request:
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm: GET /subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com?api-version=2020-06-01 HTTP/1.1
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm: Host: management.azure.com
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm: User-Agent: Go/go1.16.2 (amd64-darwin) go-autorest/v14.2.1 Azure-SDK-For-Go/v54.2.0 web/2020-06-01 HashiCorp Terraform/0.15.3 (+https://www.terraform.io) Terraform Plugin SDK/1.17.2 terraform-provider-azurerm/dev pid-222c6c49-1b0a-5959-a213-6608f9eb8820
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Correlation-Request-Id: 7f893967-58b3-5b58-8bfc-9cd8c387b7f7
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm: Accept-Encoding: gzip
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm:
2021-05-24T16:22:07.855+0200 [DEBUG] provider.terraform-provider-azurerm:
2021-05-24T16:22:08.973+0200 [TRACE] dag/walk: vertex "meta.count-boundary (EachMode fixup)" is waiting for "azurerm_app_service_managed_certificate.test"
2021-05-24T16:22:08.974+0200 [TRACE] dag/walk: vertex "provider[\"registry.terraform.io/hashicorp/azurerm\"] (close)" is waiting for "azurerm_app_service_managed_certificate.test"
2021-05-24T16:22:08.974+0200 [TRACE] dag/walk: vertex "root" is waiting for "meta.count-boundary (EachMode fixup)"
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: [DEBUG] AzureRM Response for https://management.azure.com/subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com?api-version=2020-06-01:
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: HTTP/2.0 200 OK
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Cache-Control: no-cache
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Content-Type: application/json
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Date: Mon, 24 May 2021 14:22:08 GMT
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Expires: -1
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Pragma: no-cache
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Server: Microsoft-IIS/10.0
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Strict-Transport-Security: max-age=31536000; includeSubDomains
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: Vary: Accept-Encoding
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Aspnet-Version: 4.0.30319
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Content-Type-Options: nosniff
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Correlation-Request-Id: 7f893967-58b3-5b58-8bfc-9cd8c387b7f7
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Ratelimit-Remaining-Subscription-Reads: 11987
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Request-Id: 315d96f0-d7ba-4fd4-ae35-64aabde9f45a
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Ms-Routing-Request-Id: GERMANYWESTCENTRAL:20210524T142208Z:5ee28860-58ab-4f13-846c-70900a27da3e
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm: X-Powered-By: ASP.NET
2021-05-24T16:22:09.216+0200 [DEBUG] provider.terraform-provider-azurerm:
2021-05-24T16:22:09.217+0200 [DEBUG] provider.terraform-provider-azurerm: {"id":"/subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com","name":"zone4230276816.azure.allomani.com","type":"Microsoft.Web/certificates","location":"West US","properties":{"friendlyName":"","subjectName":"zone4230276816.azure.allomani.com","hostNames":["zone4230276816.azure.allomani.com"],"pfxBlob":null,"siteName":null,"selfLink":null,"issuer":"GeoTrust TLS DV RSA Mixed SHA256 2020 CA-1","issueDate":"2021-05-24T00:00:00+00:00","expirationDate":"2021-11-23T23:59:59+00:00","password":null,"thumbprint":"E2E41BCFCD52F20E910D355190F36252B3628ED5","valid":null,"toDelete":null,"cerBlob":null,"publicKeyHash":null,"hostingEnvironment":null,"hostingEnvironmentProfile":null,"keyVaultId":"","keyVaultSecretName":"","keyVaultSecretStatus":"Initialized","webSpace":"acctestRG-asmc-4230276816-WestUSwebspace-Linux","serverFarmId":null,"canonicalName":"zone4230276816.azure.allomani.com","tags":null,"resourceGroup":"acctestrg-asmc-4230276816"}}

{
"id": "/subscriptions/eeb2ccc2-3fd0-4cab-bc73-c958c61a9b72/resourceGroups/acctestRG-asmc-4230276816/providers/Microsoft.Web/certificates/zone4230276816.azure.allomani.com",
"name": "zone4230276816.azure.allomani.com",
"type": "Microsoft.Web/certificates",
"location": "West US",
"properties": {
"friendlyName": "",
"subjectName": "zone4230276816.azure.allomani.com",
"hostNames": [
"zone4230276816.azure.allomani.com"
],
"pfxBlob": null,
"siteName": null,
"selfLink": null,
"issuer": "GeoTrust TLS DV RSA Mixed SHA256 2020 CA-1",
"issueDate": "2021-05-24T00:00:00+00:00",
"expirationDate": "2021-11-23T23:59:59+00:00",
"password": null,
"thumbprint": "E2E41BCFCD52F20E910D355190F36252B3628ED5",
"valid": null,
"toDelete": null,
"cerBlob": null,
"publicKeyHash": null,
"hostingEnvironment": null,
"hostingEnvironmentProfile": null,
"keyVaultId": "",
"keyVaultSecretName": "",
"webSpace": "acctestRG-asmc-4230276816-WestUSwebspace-Linux",
"serverFarmId": null,
"canonicalName": "zone4230276816.azure.allomani.com",
"tags": null,
"resourceGroup": "acctestrg-asmc-4230276816"
}
}
```

Contributor guide

Open the contributing guide

Research direction

Start with the linked Certificates.json specification and compare its createOrUpdate and get definitions with the REST API documentation cited in the issue. Reproduce the tags request and response behavior, then determine whether the specification or the service behavior is inconsistent; done means the discrepancy is resolved and the relevant API definition accurately reflects the supported behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.