Azure / Azure/azure-rest-api-specs

[Search] skillsetCount in ServiceCounters Shouldn't be Required

Open
#13,963 2 comments 0 reactions 0 assignees View on GitHub
Search
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

The current service preview Swagger for Search service added a new property to `ServiceCounters` as required.

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/search/data-plane/Azure.Search/preview/2020-06-30-Preview/searchservice.json#L9149

From an SDK perspective having this new parameter as required would cause SDKs generated on the latest Swagger to fail during deserialization if an older API version of Search was called. This new parameter should be optional, removed from being required.

Contributor guide

Open the contributing guide

Research direction

Open specification/search/data-plane/Azure.Search/preview/2020-06-30-Preview/searchservice.json at the ServiceCounters definition near line 9149. Check how skillsetCount is listed in the required properties, then verify that the property is optional so SDKs generated from the preview specification can deserialize responses from older Search API versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.