Azure / Azure/azure-rest-api-specs
networksets.json schema misses definition for member/property trustedServiceAccessEnabled
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 444
Description
I see Preview API 2018-01-01-preview accepts trustedServiceAccessEnabled property to configure "Allow trusted Microsoft services to bypass this firewall?" config and updates configuration correctly,
https://management.azure.com/subscriptions/XXX-XXXX-426a-b770-XXX/resourceGroups/xxxx/providers/Microsoft.ServiceBus/namespaces/xxxx/networkrulesets/default?api-version=2018-01-01-preview
{"id":"/subscriptions/XXX-XXXX-426a-b770-XXX/resourceGroups/xxxx/providers/Microsoft.ServiceBus/namespaces/xxxx/networkrulesets/default","properties":{"defaultAction":"Deny","ipRules":[],"virtualNetworkRules":[],"**trustedServiceAccessEnabled":true**}}
However, Swagger definition (schema) is missing the property.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2018-01-01-preview/networksets.json
This could be the reason the documentation is missing it too.
Could you please check and confirm if this needs correction?
https://docs.microsoft.com/en-us/rest/api/servicebus/preview/namespaces%20-%20network%20rule%20set/createorupdatenetworkruleset#request-body
Contributor guide
Research direction
Open specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2018-01-01-preview/networksets.json and inspect the network rule set properties definition. Compare it with the documented Preview API response and request body for trustedServiceAccessEnabled. Done means the schema represents this property consistently with the accepted API configuration and the related documentation is no longer missing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- openapi
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100