Azure / Azure/azure-quickstart-templates

Bug with azure-quickstart-templates - 201-vmss-linux-nat template

Open
#3,043 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Bicep
Stars
14.9k
Forks
16.2k
Avg merge
6d 21h
Merged PRs (30d)
6

Description

--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------

Sorry to hear you had a bad experience with one of the templates :worried: But, in case you're just asking a question, we're happy to help. You can also check if the question might already have been asked here https://github.com/Azure/azure-quickstart-templates/issues?utf8=%E2%9C%93&q=is%3Aissue

We've created an outline of recommended sections to fill out that will help make this Pull Request awesome!

--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------

azure-quickstart-templates/201-vmss-linux-nat template

### Issue Details

Template variable newStorageAccountSuffix uses namingInfix variable which comes from the VMSS name.
This is a problem because if I choose a VMSS with a name that has a "-" character, the deployment fails because the "-" character will be inherited by the namingInfix and then end up in the newStorageAccountSuffix. The newStorageAccountSuffix variable cannot have a "-" because storage account creation will fail with message : "xxxx-xxxx is not a valid storage account name. Storage account name must be between 3 and 24 characters in length and use numbers and lower-case letters only.

To reproduce, try deploying this template and have a VMSS name that has a "-" character in its name.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the azure-quickstart-templates/201-vmss-linux-nat template and inspect how namingInfix is used to form newStorageAccountSuffix. Reproduce the deployment with a VMSS name containing a hyphen, then verify that the generated storage account name uses only permitted characters and the deployment succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.