Azure / Azure/azure-quickstart-templates
Comments in code and the actual code does not match for RoutingIntent
- Dominant language
- Bicep
- Stars
- 14.9k
- Forks
- 16.2k
- Avg merge
- 6d 21h
- Merged PRs (30d)
- 6
Description
[Azure Virtual WAN Routing Intent and Policies](https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.network/virtual-wan-routing-intent/)
### Issue Details
The code does not do as the comment [here](https://github.com/Azure/azure-quickstart-templates/blob/07e75ae6d8d528a568b9f928faa0b51e9cde9415/quickstarts/microsoft.network/virtual-wan-routing-intent/main.bicep#L55) and [here](https://github.com/Azure/azure-quickstart-templates/blob/07e75ae6d8d528a568b9f928faa0b51e9cde9415/quickstarts/microsoft.network/virtual-wan-routing-intent/modules/routingintent.bicep#L4C).
The conditional expression in routingintent.bicep does as expected for the true-true and true-false case but both the false-false and false-true case will deploy a PrivateTrafficRoutingPolicy. The comments says that false-false will disable the RoutingIntent feature which is not the case.
Either change comment or correct the code.
Contributor guide
No contributing guide indexed for this repository
Research direction
Read the comments in quickstarts/microsoft.network/virtual-wan-routing-intent/main.bicep and modules/routingintent.bicep, then inspect the conditional expression in routingintent.bicep. Compare the documented true-true, true-false, false-false, and false-true behavior with the deployed policy. Done when the comments and implementation agree for every case, with the chosen behavior reflected consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100