Azure / Azure/azure-powershell

Does the Expire Time of AccessToken Make Sense

Open
#25,368 0 comments 0 reactions 1 assignee Claimed by @msJinLei View on GitHub
Authentication Azure PS Team potential-pruning question Tracking
Dominant language
C#
Stars
4.8k
Forks
4.3k
Avg merge
2d 17h
Merged PRs (30d)
51

Description

### Description

The following code snippet is to manually sets the expire time of access token. But token's real expire time is earlier. Can we find a better way to handle it?
``` csharp
public override AccessToken GetToken(TokenRequestContext requestContext, CancellationToken cancellationToken)
{
AccessToken token;
this.accessToken.AuthorizeRequest((tokenType, tokenValue) =>
{
token = new AccessToken(tokenValue, DateTimeOffset.UtcNow);
});

return token;
}

public override ValueTask GetTokenAsync(TokenRequestContext requestContext, CancellationToken cancellationToken)
{
AccessToken token;
this.accessToken.AuthorizeRequest((tokenType, tokenValue) =>
{
token = new AccessToken(tokenValue, DateTimeOffset.UtcNow);
});

return new ValueTask(token);
}
}
}
```
The related source codes
- src/CosmosDB/CosmosDB/Helpers/CosmosDBSessionCredential.cs
- src/Storage/Storage/Common/AzureSessionCredential.cs
- src/Synapse/Synapse/Common/AzureSessionCredential.cs

### Script or Debug output

_No response_

### Environment data

_No response_

### Module versions

_No response_

### Error output

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.