Azure / Azure/azure-powershell

[Eng]: Static Analysis skips checking modules if GitHub API request exceeds rate limit

Open
#17,360 0 comments 0 reactions 0 assignees View on GitHub
Engineering
Dominant language
C#
Stars
4.8k
Forks
4.3k
Avg merge
2d 17h
Merged PRs (30d)
51

Description

### Description

## Issue
Static Analysis skips checking modules and reports false negative if GitHub API request exceeds rate limit.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1405507&view=logs&j=e1b7b984-9f58-529f-7c5a-f15f8e35cfa6&t=e8689ae8-b216-55f7-b207-4831f84ff98a

## Exception message
PullRequestNumber:17292
---Exception Caught when trying to detect file changes with PS script: Octokit.RateLimitExceededException: API rate limit exceeded for 52.237.181.252. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)
at Octokit.Connection.HandleErrors(IResponse response) in /Users/shiftkey/src/octokit.net/Octokit/Http/Connection.cs:line 665
at Octokit.Connection.RunRequest(IRequest request, CancellationToken cancellationToken) in /Users/shiftkey/src/octokit.net/Octokit/Http/Connection.cs:line 643
at Octokit.Connection.Run[T](IRequest request, CancellationToken cancellationToken) in /Users/shiftkey/src/octokit.net/Octokit/Http/Connection.cs:line 628
at Octokit.Internal.ReadOnlyPagedCollection`1.GetNextPage() in /Users/shiftkey/src/octokit.net/Octokit/Http/ReadOnlyPagedCollection.cs:line 40
at Octokit.ApiPagination.GetAllPages[T](Func`1 getFirstPage, Uri uri)
at Microsoft.WindowsAzure.Build.Tasks.FilesChangedTask.Execute() in D:\a\1\s\tools\BuildPackagesTask\Microsoft.Azure.Build.Tasks\FilesChangedTask.cs:line 104
{"message":"API rate limit exceeded for 52.237.181.252. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"[https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}](https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting%22})

## Potential solution
Authenticated requests get a higher rate limit. Check out the documentation for more details: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.