Azure / Azure/azure-policy

ASC_Storage_DisallowPublicBlobAccess_Audit: Duplicate 'effects' parameter in policy definition

Open
#1,065 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Open Policy Agent
Stars
1.7k
Forks
1.2k
Avg merge
2d 54m
Merged PRs (30d)
3

Description

## ISSUE TITLE:
ASC_Storage_DisallowPublicBlobAccess_Audit: [Bug] Duplicate 'effects' parameter

## ISSUE DESCRIPTION:
Policy: https://github.com/Azure/azure-policy/blob/master/built-in-policies/policyDefinitions/Storage/ASC_Storage_DisallowPublicBlobAccess_Audit.json

The policy lists duplicate 'effects' as possible parameter values.
![image](https://user-images.githubusercontent.com/4426330/204461547-d608f908-e4ed-42f7-a47c-ede0caf2a5ec.png)

**Expected**
Duplicates should be removed, consistent with other built in policies.

**Actual**
Duplicate effects are listed.

**Note**
It seems that the schema only supports low case values, but built-in policys typically use an uppercase first letter:
![image](https://user-images.githubusercontent.com/4426330/204414043-7bc4398c-9400-4434-8bcb-b2816ceadffa.png)
https://schema.management.azure.com/schemas/2020-10-01/policyDefinition.json

It is not possible to save a policy in Azure Portal with uppercase effect name:
![image](https://user-images.githubusercontent.com/4426330/204414170-59be39a7-1fdc-45f2-9920-8e78e98c60d8.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Open built-in-policies/policyDefinitions/Storage/ASC_Storage_DisallowPublicBlobAccess_Audit.json and inspect the effects parameter values. Compare its allowed values with nearby built-in policies and the referenced policy-definition schema. Done means the duplicate effect entry is removed and the remaining values follow the repository's established casing and schema expectations.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure
Domain
cloud, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.