Azure / Azure/azure-openapi-validator

[RequiredPropertiesMissingInResourceModel] some model definitions are mistakenly identified as resource models

Open
#773 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
53
Forks
57
Avg merge
1d 23h
Merged PRs (30d)
2

Description

**Describe the bug**
It seems that some definitions that are not resource models are also considered resource models.

https://github.com/Azure/azure-rest-api-specs/pull/33237/checks?check_run_id=38861178342

https://github.com/Azure/azure-rest-api-specs/blob/e77744e766cf3251d8f4242605d8acdbe2c7b8fe/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-01-02-preview/managedClusters.json#L10258

```json
"NodeImageVersionsListResult": {
"description": "Holds an array NodeImageVersions",
"properties": {
"value": {
"description": "Array of AKS Node Image versions.",
"items": {
"$ref": "#/definitions/NodeImageVersion"
},
"type": "array",
"x-ms-identifiers": [
"fullName"
]
},
"nextLink": {
"description": "The URL to get the next set of machine results.",
"format": "uri",
"readOnly": true,
"type": "string"
}
},
"type": "object"
},
"NodeImageVersion": {
"description": "node image version profile for given major.minor.patch release.",
"properties": {
"os": {
"description": "The operating system of the node image. Example: AKSUbuntu",
"type": "string"
},
"sku": {
"description": "The SKU or flavor of the node image. Example: 2004gen2containerd",
"type": "string"
},
"version": {
"description": "major.minor.patch version of the node image version release. Example: 2024.02.02",
"type": "string"
},
"fullName": {
"description": "The OS + SKU + version of the node image. Example: AKSUbuntu-1804gen2containerd-2024.02.02",
"type": "string"
}
},
"type": "object"
}
},
```

**To Reproduce**
Steps to reproduce the behavior:

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.