Azure / Azure/azure-openapi-validator

revisit rules for arm tenant resource

Open
#403 4 comments 0 reactions 0 assignees View on GitHub
api-rule
Dominant language
TypeScript
Stars
53
Forks
57
Avg merge
1d 23h
Merged PRs (30d)
2

Description

Since tenant resources have different linting requirements, we need to revisit the below rules to as they apply to arm resources

# For all resources:

AllResourcesMustHaveDelete : should be a warning

AllResourcesMustHaveGetOperation :

AzureResourceTagsSchemaValidation: it checks if the 'tags' property is same with common types

NestedResourcesMustHaveListOperation: nested resource list by the immediate parent resource

TopLevelResourcesListByResourceGroup:

TopLevelResourcesListBySubscription:

CreateOperationAsyncResponseValidation:

PathForPutOperation: The path for 'put' operation must be under a subscription and resource group.

PutGetPatchResponseSchema: put get, patch have same response schema

PutRequestResponseScheme: put request and response schema should be the same one

RepeatedPathInfo: path info should not repeated in the resourcec model

RequiredPropertiesMissingInResourceModel: 'id','name','type' should be present in the resource model

PatchSkuProperty: sku should be present when a resource has the 'sku'

PatchIdentityProperty: identity should be present when resource has the 'identity'

PatchBodyParametersSchema: patch properties must not have properties flagged with required or default or 'x-ms-mutability:"create"'

ConsistentPatchProperties: patch properties should be present in the resource model

# For tracked resource only

TrackedResourceBeyondsThirdLevel

TrackedResourcePatchOperation

TrackedResourceGetOperation

TrackedResourcesMustHavePut

XmsPageableListByRGAndSubscriptions

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.