Azure / Azure/azure-openai-benchmark

Count of Completed Requests & Total Requests is same

Open
#40 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
154
Forks
76
PR merge metrics
No merged PRs in 30d

Description

I was having a look at my output logs and StatsAggregator class.

I would like to understand the reason for keeping the same value of "total number of requests" for both "completed" & "requests" keys?

image

If by "completed", we wanted to mean "successful" , then the count should be (total requests-failed requests)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the StatsAggregator class and tracing how the output-log values for "completed", "requests", and "failed" are calculated. Compare the current behavior with the issue's proposed meaning of completed as successful requests. Done means the counters have distinct, clearly defined semantics and the reported values match those definitions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
analytics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.