Azure / Azure/azure-kusto-node
Parameters set in the clientRequestProperties are not sanitized to "dynamic" when needed
- Dominant language
- TypeScript
- Stars
- 54
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
Hey,
Could not find the place where the `parameters` are converted to their kusto types, as described [here](https://docs.microsoft.com/en-us/azure/data-explorer/kusto/query/queryparametersstatement?pivots=azuredataexplorer#specifying-query-parameters-in-a-client-application).
For example, if I specify a date parameter:
```javascript
clientRequestProperties.setParameter('startTime', new Date().toISOString());
```
Then something in your package will wrap the value with `datetime()`.
However, if I provide an array of values:
```javascript
clientRequestProperties.setParameter('ids', [1,2,3]);
```
The package will not sanitize it to `dynamic()`.
Tried looking for the actual code doing this sanitization, however I couldn't find it.
https://github.com/Azure/azure-kusto-node/blob/6f774914049f076a8d6cfbe0a8231b5c962e8ba8/azure-kusto-data/source/clientRequestProperties.ts#L64-L80
Contributor guide
Assessment
This issue has not been assessed yet.