Azure / Azure/azure-iot-hub-node

Breaking change in 1.16.5 due to removal of (deprecated) authentication.SymmetricKey

Open
#39 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3
Forks
18
PR merge metrics
No merged PRs in 30d

Description

This [change](https://github.com/Azure/azure-iot-hub-node/pull/38/files#diff-821fa6c4e39b57ef456dea4e0e887d8aed145922eeefee56eeb0ebb8c3646828L133) removed SymmetricKey compatibility property from Device class.
Given, both property and the class have been [marked as deprecated](https://github.com/Azure/azure-iot-hub-node/blob/721a69a0a6bcc4c79690491cf8716d77d8d99d7e/src/device.ts#L32C20-L32C30) for a while, but feels like 1.16.4->1.16.5 is not the "major" release - so it affects users relying on semantic versioning.
In addition - if it is indeed being removed intentionally - maybe the [test](https://github.com/Azure/azure-iot-hub-node/blob/57f950ee58c3e0a465f34345950db8cdbc89d8cc/test/_device_test.js#L45) could also be cleaned up.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.