Azure / Azure/azure-functions-sql-extension

Change commandText property/parameter name

Open
#569 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
130
Forks
71
Avg merge
4d 8h
Merged PRs (30d)
4

Description

Currently input and output bindings share an attribute - and with that share the [commandText](https://github.com/Azure/azure-functions-sql-extension/blob/main/src/SqlAttribute.cs#L44) property/parameter

This value can be multiple things based on the type of binding :

Input - Either a query or the name of a stored procedure
Output - The table name to upsert to

So out of the 3 potential options only one is really a "commandText".

To make it much more clear we should consider the following :

- Renaming it to `queryOrStoredProcedure` and using that for input bindings
- Adding a new property/parameter `tableName` and using that for output bindings (similar to the trigger attribute)

This is a pretty big breaking change, but would help make things a lot more clear when using the bindings.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.