Azure / Azure/azure-functions-powershell-worker

Durable orchestration with special characters

Open
#932 1 comment 1 reaction 0 assignees View on GitHub
Needs: Investigation :mag:
Dominant language
C#
Stars
215
Forks
61
Avg merge
21h 4m
Merged PRs (30d)
6

Description

We pass the HTTP trigger’s request to the durable orchestrator.
Inside this worker (*Start-DurableOrchestration*) the request is JSON encoded but forwarded (*Invoke-RestMethod*) without a charset, so we lose special characters (e.g.: äöüß) in the request.

https://github.com/Azure/azure-functions-powershell-worker/blob/4a1bcd57ab0bffccc6769a8d57dc353db61fd73b/src/Modules/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psm1#L132

Please change the ContentType parameter to “**application/json;charset=utf-8**”.
See pull request: #931

To workaround we encode the request with base64 before passing it to *Start-DurableOrchestration* and decode the *Context.Input* in the orchestrator before invoking the durable activity. Do you see any negative impacts on the workaround?
Or are we doing it completely wrong and should pass the request in another way to the activity?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at src/Modules/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psm1 around line 132, where Start-DurableOrchestration forwards the JSON request with Invoke-RestMethod. Check the existing pull request #931 and verify that the request ContentType preserves characters such as äöüß when passed to the durable orchestrator.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, powershell
Domain
backend, cloud
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.