Azure / Azure/azure-functions-powershell-opentelemetry

Activity tag propogation discussion

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Discussion:
Currently, we propagate all custom tags added to Activity.Current to all child spans on creation. The intent behind this decision was to ensure that all user spans contained the InvocationId as a property. However, this means that if a user defines a span, adds a tag, and then creates a child span, it will inherit these tags as well, which is divergent behavior from the System.Diagnostics Activity class that our spans are based on. Is this an issue, should we limit propagation to InvocationId? Limit it further to InvocationId to spans that are direct children of the internal span? or remove it entirely? Open to discussion

Contributor guide

Open the contributing guide

Research direction

The issue names no file or test. Start by reviewing the current Activity.Current child-span tag propagation and comparing it with System.Diagnostics.Activity; done means reaching a decision on whether to propagate all tags, only InvocationId in the stated scopes, or none.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
observability
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.