Azure / Azure/azure-functions-host
On timeout fail other executions from same worker to know cause.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 482
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 38
Description
**NOTE: This does not have an impact on executions, just on the cause of the execution failure.**
Need to verify that failing other executions from a timeout won't alter behavior, ex: in the case of event hubs trigger.
[RestartWorkerWithInvocationIdAsync](https://github.com/Azure/azure-functions-host/blob/f7316c51241234363b11e80cb22f2f4add5252f3/src/WebJobs.Script/Workers/Rpc/FunctionRegistration/RpcFunctionInvocationDispatcher.cs#L430) needs to take in an exception that flows through [TryFailExecutions](https://github.com/Azure/azure-functions-host/blob/0806346aec7e28dbbda4033a64b2c046534895fd/src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs#L602)
Also, should log whether or not channel was found:
https://github.com/Azure/azure-functions-host/blob/aef1c91718a44e7e2984f29f11be56ab6d7daf74/src/WebJobs.Script.WebHost/WebScriptHostExceptionHandler.cs#L57
Contributor guide
Research direction
Start with RestartWorkerWithInvocationIdAsync in src/WebJobs.Script/Workers/Rpc/FunctionRegistration/RpcFunctionInvocationDispatcher.cs and TryFailExecutions in src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs. Trace timeout handling and verify that failing other executions does not alter event hubs trigger behavior. Check WebScriptHostExceptionHandler.cs to determine how to log whether a channel was found; done means the failure cause is propagated and the behavior is covered by verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, csharp
- Domain
- backend, cloud
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100