Azure / Azure/azure-functions-host

FunctionInstanceLogger is initialized with a null LoggerFactory

Open
#2,223 0 comments 0 reactions 0 assignees View on GitHub
2.x area: dependency injection area: engineering
Dominant language
C#
Stars
2k
Forks
482
Avg merge
2d 12h
Merged PRs (30d)
38

Description

Once #2182 is implemented, the `FunctionInstanceLogger` that is created in the `WebScriptHostManager` has a null `LoggerFactory`. This is because it is created before the `ScriptHost` has been initialized, which is when the LoggerFactory is created. We'll need to refactor this, but it may be done during our DI refactor.

Contributor guide

Open the contributing guide

Research direction

Start with the FunctionInstanceLogger creation in WebScriptHostManager and trace how ScriptHost initializes LoggerFactory, including the changes from #2182. Determine a lifecycle or dependency-injection refactor that prevents a null LoggerFactory, then verify that FunctionInstanceLogger is created with the initialized factory.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend, cloud
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.