Azure / Azure/azure-functions-host

Unify the HttpClient usage for avoiding anit-patterns

Open
#11,342 0 comments 0 reactions 0 assignees View on GitHub
Needs: Triage (Functions)
Dominant language
C#
Stars
2k
Forks
482
Avg merge
2d 12h
Merged PRs (30d)
38

Description

We found some spots that does not use HttpClient properly. Also find lack of using on the following code.
Review the following two files and use HttpClient properly.

We should use:
* HttpClientFactory with User Agent with DI
* Proper Retry-Handling using Polly if it necessary

List the Pointers:
* PowerShellFileProvisioner
* KubernetesClient

Contributor guide

Open the contributing guide

Research direction

Locate the PowerShellFileProvisioner and KubernetesClient implementations and review how each currently creates or uses HttpClient. Define completion as both using HttpClientFactory with a User-Agent supplied through DI, with Polly retry handling where necessary; the issue does not name specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.