Azure / Azure/azure-functions-dotnet-worker

[ASP.NET Core Integration] Evaluate coordination of services in ASP.NET and gRPC/Functions pipeline

Open
#2,189 1 comment 0 reactions 1 assignee Assigned to @satvu View on GitHub
area: http design needs-investigation
Dominant language
C#
Stars
466
Forks
215
Avg merge
3d 10h
Merged PRs (30d)
7

Description

To coordinate both pipelines to use the same scope, there is logic like [this](https://github.com/Azure/azure-functions-dotnet-worker/blob/49cc0270da5f12b8d7cb133b48ded39ed2e04778/extensions/Worker.Extensions.Http.AspNetCore/src/AspNetMiddleware/WorkerRequestServicesMiddleware.cs#L30). Due to the cancellation callback [here](https://github.com/Azure/azure-functions-dotnet-worker/blob/49cc0270da5f12b8d7cb133b48ded39ed2e04778/extensions/Worker.Extensions.Http.AspNetCore/src/Coordinator/ContextReference.cs#L38), the task that signals the gRPC/functions pipeline to move backwards leads to a race condition as services may still be used in either pipeline.

Creating this issue to track investigation, design, and implementation of a solution to make sure both pipelines unwind correctly and objects are not disposed early. Related to #1929.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.