Azure / Azure/azure-functions-dotnet-worker

IBinder/Binder is preserved by Upgrade Assistant

Open
#2,014 0 comments 0 reactions 1 assignee Claimed by @aishwaryabh View on GitHub
area: dotnet-upgrade-assistant bug team-issue
Dominant language
C#
Stars
466
Forks
215
Avg merge
3d 10h
Merged PRs (30d)
7

Description

When Upgrade Assistant encounters an in-process model project with `IBinder` or `Binder`, it doesn't make any changes. This leads to two build errors after the upgrade. One is for the type itself in the function parameters:

>Error CS0246 The type or namespace name 'IBinder' could not be found (are you missing a using directive or an assembly reference?)

The other would be for any attributes that are defined in the function body which would interact with the `IBinder`. For example:

>Error CS0246 The type or namespace name 'BlobAttribute' could not be found (are you missing a using directive or an assembly reference?)

The latter should be maintained (it's an error within the function body). However, we should consider removing the `IBinder` parameter from the signature. This will just move the error to wherever the `IBinder` was used, but that will also be in the function body. A code comment should be added alongside this removal that explains the change and points them to https://aka.ms/af-dotnet-isolated-migration for instructions on how to change this behavior.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.