Azure / Azure/azure-functions-core-tools

Could KeyVaultReferencesManager move to a non-functions library?

Open
#2,986 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.5k
Forks
498
Avg merge
4d 20h
Merged PRs (30d)
14

Description

The [KeyVaultReferencesManager](https://github.com/Azure/azure-functions-core-tools/blob/v4.x/src/Azure.Functions.Cli/Common/KeyVaultReferencesManager.cs) looks like a great starting point for having a general purpose way of resolving key vault references outside of Azure App Service/Function Settings.
If it could be refactored a bit (e.g. TokenCredential via constructor injection) it would be a great utility to have in a more common key vault library (e.g. [here](https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/keyvault/Azure.Security.KeyVault.Secrets)).
An example use-case would be a dynamic, run-time configuration change that is not driven by app settings (e.g. loaded from a third party settings api, REST, DB ...).

Contributor guide

Open the contributing guide

Research direction

Start with src/Azure.Functions.Cli/Common/KeyVaultReferencesManager.cs and compare its responsibilities with the Azure.Security.KeyVault.Secrets library. Clarify whether the reusable utility belongs in this repository or the linked Azure SDK repository, and define the TokenCredential constructor-injection scope. Done means an agreed general-purpose Key Vault reference resolver usable outside Azure Functions settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, csharp
Domain
cloud, security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.