Azure / Azure/azure-functions-core-tools

Fix issue with missing "workers" directory

Open
#2,380 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.5k
Forks
498
Avg merge
5d 4h
Merged PRs (30d)
15

Description

Recently, we updated how we build the minified core tools projects ([here](https://github.com/Azure/azure-functions-core-tools/commit/b4e66eb3370e6217d76290ad38726e7a3a380857)). Previously, we would build with all workers and then empty the "workers" directory. The change linked above changed that to not add workers for minified runtimes, which seems the right way to do it.

However, this broke a couple of scenarios where if a user does not have `FUNCTIONS_WORKER_RUNTIME` set, the minified package would throw an error as the host isn't able to get the worker information from the "workers" directory. Just having an empty "workers" directory fixes this issue.

We made a quick fix to revert this here -- https://github.com/Azure/azure-functions-core-tools/pull/2378
But, we should come up with the proper approach to tackle this.

Contributor guide

Open the contributing guide

Research direction

Inspect the minified runtime build change in commit b4e66eb3370e6217d76290ad38726e7a3a380857 and compare it with the workaround in pull request 2378. Reproduce the scenarios where FUNCTIONS_WORKER_RUNTIME is unset, then verify that the minified package provides the required workers directory without restoring unnecessary workers. Done means those scenarios no longer fail while minified packages retain their intended contents.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.