Azure / Azure/azure-functions-core-tools

Allow configuration of osiris.deislabs.io/ingressHostname upon Kubernetes deployment

Open
#1,310 5 comments 1 reaction 1 assignee Claimed by @ahmelsayed View on GitHub
Kubernetes
Dominant language
C#
Stars
1.5k
Forks
498
Avg merge
5d 4h
Merged PRs (30d)
15

Description

Currently the CLI allows specifying the service type upon deployment, defaulting to LoadBalancer.

With service type LoadBalancer we'd end up with a Kubernetes provisioned Azure load balancer resource per function, which I believe in most real world cases would be undesirable.

Assuming that most users have their clusters setup with an ingress, it'd make sense to allow configuration of the osiris annotation ingressHostname, as it's required for Osiris to work if the services in question are accesses through an ingress.

Happy to provide a pull request if this makes sense to the team.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.