Azure / Azure/azure-devops-cli-extension

[Bug] or [Features] az repos policy approver-count

Open
#1,091 3 comments 6 reactions 0 assignees View on GitHub
Feature
Dominant language
Python
Stars
682
Forks
278
Avg merge
3d 23h
Merged PRs (30d)
3

Description

`az repos policy approver-count` `create` and `update` is missing the settings:
![image](https://user-images.githubusercontent.com/60382556/105704596-57f8bf80-5f0f-11eb-9cf7-e5f6ff38c866.png)

First it prevent us from setting it from AZ CLI and if we try to update an existing policy it will reset missing settings that was set from web site or other tools.

**Describe the solution you'd like**

https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/repos/policy/approver-count?view=azure-cli-latest#ext_azure_devops_az_repos_policy_approver_count_create
and
https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/repos/policy/approver-count?view=azure-cli-latest#ext_azure_devops_az_repos_policy_approver_count_update
gets a new Optional Parameters
called `blockLastPusherVote`

**Additional context**
It would be an idea to change the update to a PATCH request instead of a PUT.
So it does not override settings az cli dont know about.
Note: It require that https://docs.microsoft.com/en-us/rest/api/azure/devops/policy/configurations/update?view=azure-devops-rest-6.0 will be update to support PATCH request.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.