Azure / Azure/azure-dev

[Build] Fix a potential issue with too many tags?

Open
#8,741 0 comments 0 reactions 0 assignees View on GitHub
area/pipeline bug engsys
Dominant language
Go
Stars
569
Forks
364
Avg merge
2d 20h
Merged PRs (30d)
147

Description

This review feedback came out on a PR I made for the nightly builds. It's not related to the changes, but looks like it might need fixing:

> The tag existence check uses gh api /repos/.../tags, which only returns the first page of tags (typically 30). If the repo has more tags, an existing tag may be missed and the pipeline will fail later when creating the release. Use the git ref endpoint to check the specific tag directly (404 => not found). (azd-code-reviewer)

https://github.com/Azure/azure-dev/pull/8740#discussion_r3445247211

Contributor guide

Open the contributing guide

Research direction

Read the nightly-build changes and review discussion in PR #8740 first. Trace the tag existence check and verify the specific git-ref lookup behavior for existing and missing tags; done means pagination no longer causes an existing tag to be treated as absent and the relevant build check passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, github-actions
Domain
build-system, ci-cd, release
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
57/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.