Azure / Azure/azure-cli

[Network] `vnet-gateway vpn-client generate` workarounds

Open
#4,392 8 comments 0 reactions 0 assignees View on GitHub
act-quality-productivity-squad Network Network - VPN Gateway Service Attention
Dominant language
Python
Stars
4.6k
Forks
3.5k
Avg merge
3d 2h
Merged PRs (30d)
60

Description

To implement #4249, two workarounds were needed.

1. The SDK implementation of these commands was duplicated in the CLI and referenced directly due to a bug in autorest that would not accept a 202 status code.
2. The service implementation sends both Azure-AsyncOperation and Location headers. The Async-Operation header is used for absolutely nothing, but the service wants you to poll on the Location header. msrestazure is designed such that if both are present, Azure-AsyncOperation takes precedence as it is an optional header. Removal of the Azure-AsyncOperation header by the service would remove the need for this workaround.

cc/ @lmazuel, @aanandr

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.