ACR self.cmd did not detect command failure
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 3.5k
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 60
Description
### Describe the bug
ACR team uses the self.cmd command to confirm that our command successfully runs with no errors. However, we have noticed that our test using self.cmd still passes even though our `acr agentpool delete` command returns an error
https://github.com/Azure/azure-cli/blob/f92f7233659890b427f4f6f486db5610cdca1020/src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_agentpool_commands.py#L67
### Related command
acr agentpool delete -n {agents2_name} -r {registry_name}
### Errors
NA
### Issue script & Debug output
NA
### Expected behavior
Test fail when command returns an error message
### Environment Summary
`{
"auzre-cli": "2.67.0",
"azure-cli-core": "2.67.0",
"azure-cli-telemetry": "1.1.0",
"extensions": {
"acrtransfer": "1.1.0"
}
}`
### Additional context
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.