Azure / Azure/azure-cli

Please update docs for network firewall policy rule update to reflect correct protocols

Open
#19,310 1 comment 0 reactions 1 assignee Claimed by @kairu-ms View on GitHub
act-quality-productivity-squad customer-reported feature-request Network
Dominant language
Python
Stars
4.6k
Forks
3.5k
Avg merge
3d 2h
Merged PRs (30d)
60

Description

Hello,

I recently found an issue with the docs on this page: https://docs.microsoft.com/en-us/cli/azure/network/firewall/policy/rule-collection-group/collection/rule?view=azure-cli-latest#az_network_firewall_policy_rule_collection_group_collection_rule_update

**--protocols**
`Space-separated list of protocols and port numbers to use, in PROTOCOL=PORT format. Valid protocols are Http, Https.
--remove`

In the portal, in addition to Http and Https it is possible (and needed) to add Mssql as a valid protocol to a Firewall Policy Rule Collection.

Despite the documentation, I ran the command including Mssql protocol and it worked.
`az network firewall policy rule-collection-group collection rule update --collection-name MyCollection --name AllowAKSMicrosoft --policy-name MyPolicyName --rcg-name DefaultApplicationRuleCollectionGroup --resource-group MyResourceGroup --protocols Https=443 Mssql=1433`

However, the corresponding [Terraform module in azurerm provider](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/firewall_application_rule_collection) only accepts Http and Https.

**Request is to review and update the docs, so that Terraform implementation can match it.**

Hope it helps,

Best regards,

-Luis

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: 51bc8847-2744-bb66-7b83-0518aa47536c
* Version Independent ID: c1c31748-e899-dd98-e418-e01ed781a14a
* Content: [az network firewall policy rule-collection-group collection rule](https://docs.microsoft.com/en-us/cli/azure/network/firewall/policy/rule-collection-group/collection/rule?view=azure-cli-latest#az_network_firewall_policy_rule_collection_group_collection_rule_update)
* Content Source: [latest/docs-ref-autogen/network/firewall/policy/rule-collection-group/collection/rule.yml](https://github.com/MicrosoftDocs/azure-docs-cli/blob/master/latest/docs-ref-autogen/network/firewall/policy/rule-collection-group/collection/rule.yml)
* Service: **virtual-network**
* GitHub Login: @rloutlaw
* Microsoft Alias: **routlaw**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.