Azure / Azure/azure-cli-extensions

connectedk8s - move to microsoft graph from the legacy aad graph call

Open
#6,485 6 comments 0 reactions 0 assignees View on GitHub
AAD Graph Auto-Assign bug Connected Kubernetes Service Attention
Dominant language
Python
Stars
454
Forks
1.7k
Avg merge
2d 19h
Merged PRs (30d)
64

Description

### Describe the bug

Azure AD graph is on the path of deprecation. Microsoft Graph should be used for the graph calls
https://devblogs.microsoft.com/microsoft365dev/microsoft-graph-or-azure-ad-graph/

code path - https://github.com/Azure/azure-cli-extensions/blob/066fc43ade5436ef0ebfc493799a19cc711d1d97/src/connectedk8s/azext_connectedk8s/custom.py#L2185

### Related command

>az connectedk8s enable-features -n balacluster2 -g baladelete2 --features cluster-connect custom-locations --debug

This is making the following graph call
urllib3.connectionpool: [https://graph.windows.net:443](https://graph.windows.net/) "GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipals?$filter=displayName%20eq%20%27Custom%20Locations%20RP%27&api-version=1.6 HTTP/1.1" 200 1246

### Errors

No errors in Azure.

### Issue script & Debug output

urllib3.connectionpool: [https://graph.windows.net:443](https://graph.windows.net/) "GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipals?$filter=displayName%20eq%20%27Custom%20Locations%20RP%27&api-version=1.6 HTTP/1.1" 200 1246

### Expected behavior

N/A

### Environment Summary

N/A

### Additional context

The issue happens in disconnected clouds where only the latest Microsoft Graph is supported

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.