Azure / Azure/azure-cli-dev-tools

az dev extension create - generates code that doesn't pass tests

Open
#107 1 comment 0 reactions 0 assignees View on GitHub
code gen enhancement
Dominant language
Python
Stars
91
Forks
134
Avg merge
2h 51m
Merged PRs (30d)
1

Description

I think this is very low priority, but just adding it for the record.
It would be nice that code generated could pass the tests out of the box.

************* Module azext_apimgmt.__init__
C: 20, 0: Wrong continued indentation (add 2 spaces).
custom_command_type=apimgmt_custom)
^ | (bad-continuation)
************* Module azext_apimgmt.custom
C: 20, 0: Final newline missing (missing-final-newline)
W: 9,19: Unused argument 'cmd' (unused-argument)
W: 9,24: Unused argument 'resource_group_name' (unused-argument)
W: 9,45: Unused argument 'apimgmt_name' (unused-argument)
W: 9,59: Unused argument 'location' (unused-argument)
W: 9,74: Unused argument 'tags' (unused-argument)
W: 13,17: Unused argument 'cmd' (unused-argument)
W: 13,22: Unused argument 'resource_group_name' (unused-argument)
************* Module azext_apimgmt.commands
C: 29, 0: Trailing newlines (trailing-newlines)
W: 7, 0: Unused CliCommandType imported from azure.cli.core.commands (unused-import)
W: 8, 0: Unused cf_apimgmt imported from azext_apimgmt._client_factory (unused-import)

************* Module azext_apimgmt._client_factory
W: 6,15: Unused argument 'cli_ctx' (unused-argument)
W: 8, 4: Unused variable 'get_mgmt_service_client' (unused-variable)

************* Module azext_apimgmt._validators
C: 9, 0: Line too long (139/120) (line-too-long)

************* Module azext_apimgmt.tests.__init__
C: 5, 0: Final newline missing (missing-final-newline)

************* Module azext_apimgmt.tests.latest.__init__
C: 5, 0: Final newline missing (missing-final-newline)

-----------------------------------
Your code has been rated at 9.99/10

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.