Azure / Azure/avocado

Avocado validate data-plane readme shouldn't have azure-arm tag

Open
#103 0 comments 0 reactions 1 assignee Assigned to @konrad-jamrozik View on GitHub
Dominant language
TypeScript
Stars
23
Forks
22
Avg merge
2d 9h
Merged PRs (30d)
13

Description

From: Mike Kistler <[mikekistler@microsoft.com](mailto:mikekistler@microsoft.com)>

Date: Thursday, April 28, 2022 at 11:16 AM
To: Anne Loomis Thompson <[annelo@microsoft.com](mailto:annelo@microsoft.com)>, Shivangi Reja <[Shivangi.Reja@microsoft.com](mailto:Shivangi.Reja@microsoft.com)>
Cc: Alexander Sher <[alsher@microsoft.com](mailto:alsher@microsoft.com)>
Subject: Re: azure-arm

Anne, Shivangi,

This is good to know! It looks like these files were copy/pasted over from the mgmt plane directory without really understanding what they do or whether they are needed.

With this knowledge, I will start looking for these in API reviews and questioning whether they are needed and whether they should be deleted.

Thanks!

Mike

From: Shivangi Reja <[Shivangi.Reja@microsoft.com](mailto:Shivangi.Reja@microsoft.com)>
Date: Wednesday, April 27, 2022 at 10:35 PM
To: Mike Kistler <[mikekistler@microsoft.com](mailto:mikekistler@microsoft.com)>, Anne Loomis Thompson <[annelo@microsoft.com](mailto:annelo@microsoft.com)>
Cc: Alexander Sher <[alsher@microsoft.com](mailto:alsher@microsoft.com)>
Subject: RE: azure-arm

Hi [@Mike](mailto:mikekistler@microsoft.com),

We don’t use `readme.csharp.md` config for any track-2 SDK in `azure-sdk-for-net` repo. We either use `readme.md` with tag(ex: [autorest.md](https://nam06.safelinks.protection.outlook.com/?url=https:%2f%2fgithub.com%2fAzure%2fazure-sdk-for-net%2fblob%2fmain%2fsdk%2fanomalydetector%2fAzure.AI.AnomalyDetector%2fsrc%2fautorest.md&data=05%7c01%7ctianxchen%40microsoft.com%7c879b9e83580e44ef438408da2e6bc720%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c637873337692906461%7cUnknown%7cTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7c3000%7c%7c%7c&sdata=QZVEjSo4Kao0B%2f8D7j%2BnXtdjLQAA%2flNBlDAhu2m0PUM%3D&reserved=0)) or we use directly the swagger file(ex: [autorest.md](https://nam06.safelinks.protection.outlook.com/?url=https:%2f%2fgithub.com%2fAzure%2fazure-sdk-for-net%2fblob%2fmain%2fsdk%2fdeviceupdate%2fAzure.IoT.DeviceUpdate%2fsrc%2fautorest.md&data=05%7c01%7ctianxchen%40microsoft.com%7c879b9e83580e44ef438408da2e6bc720%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c637873337692906461%7cUnknown%7cTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7c3000%7c%7c%7c&sdata=GNrvJqmTQzncBjYzYgQfajwOtIWHTI32Lnps5Qchk8k%3D&reserved=0)) in autorest.md for all the track-2 SDKs.

Also, we don’t use `azure-arm: true` flag for any dataplane libraries. This flag is used to generate management plane SDK.

Thanks,

Shivangi

From: Mike Kistler <[mikekistler@microsoft.com](mailto:mikekistler@microsoft.com)>
Sent: Wednesday, April 27, 2022 7:17 PM
To: Shivangi Reja <[Shivangi.Reja@microsoft.com](mailto:Shivangi.Reja@microsoft.com)>; Anne Loomis Thompson <[annelo@microsoft.com](mailto:annelo@microsoft.com)>
Subject: Re: azure-arm

I’m asking because I see this flag being used in a number of _data-plane_ services:

![Image](https://user-images.githubusercontent.com/4636380/204719833-5607d5bb-7026-4a1f-acf0-16415766c35f.png)

Would you agree that these are “bugs” and should be fixed?

Mike

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.