Azure / Azure/aks-desktop

[BUG] Cannot find module 'dmg-license' when building on Ubuntu WSL

Open
#129 2 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
102
Forks
25
Avg merge
1d 4h
Merged PRs (30d)
22

Description

## Bug Description

Build instructions fail on Ubuntu WSL.

## Steps to Reproduce

Run build steps on README.md in WSL ubuntu.

## Expected Behavior

Default build instructions don't fail.

## Actual Behavior

Default instructions try to build for mac on ubuntu and fail with missing module.

## Environment

- **OS**: Ubuntu 22.04

## Additional Context

## Logs

```
• writing effective config file=dist/builder-effective-config.yaml
⨯ Cannot find module 'dmg-license'
Require stack:
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/out/dmgLicense.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/out/dmg.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/out/dmgUtil.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/app-builder-lib/out/macPackager.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/app-builder-lib/out/packager.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/app-builder-lib/out/index.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/electron-builder/out/builder.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/electron-builder/out/cli/cli.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/electron-builder/cli.js failedTask=build stackTrace=Error: Cannot find module 'dmg-license'
Require stack:
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/out/dmgLicense.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/out/dmg.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/out/dmgUtil.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/app-builder-lib/out/macPackager.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/app-builder-lib/out/packager.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/app-builder-lib/out/index.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/electron-builder/out/builder.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/electron-builder/out/cli/cli.js
- /home/rene/dev/aks-desktop/headlamp/app/node_modules/electron-builder/cli.js
at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Module.require (node:internal/modules/cjs/loader:1487:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/home/rene/dev/aks-desktop/headlamp/app/node_modules/dmg-builder/src/dmgLicense.ts:7:1)
at Module._compile (node:internal/modules/cjs/loader:1730:14)
at Object..js (node:internal/modules/cjs/loader:1895:10)
at Module.load (node:internal/modules/cjs/loader:1465:32)
at Function._load (node:internal/modules/cjs/loader:1282:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Module.require (node:internal/modules/cjs/loader:1487:12)
make: *** [Makefile:57: app] Error 1
```

```
Paste logs here
```

## Checklist

- [x] I have searched for existing issues
- [x] I have provided all necessary information
- [x] I have tested with the latest version
- [x] I have included steps to reproduce

Contributor guide

Open the contributing guide

Research direction

Start with the build instructions in README.md and the app target at Makefile:57, then inspect the electron-builder configuration implicated by the dmg-builder stack trace. Reproduce the build on Ubuntu 22.04 under WSL and verify that the default instructions no longer attempt an unsupported macOS build or fail with the missing dmg-license module.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
build-system, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.