Azure / Azure/acr-builder

Secrets exposed when using --secretBuildArgs

Open
#644 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
41
Forks
45
Avg merge
6h 52m
Merged PRs (30d)
5

Description

There does not seem to be documentation on how to consume the values from `--secretBuildArgs` in your docker script.

If I look at the code, it seems to map to docker build args:

https://github.com/Azure/acr-builder/blob/main/cmd/acb/commands/build/build.go#L302

This is odd as the docker documentation says never to use build args for secrets as they are stored in the logs.

https://docs.docker.com/engine/reference/builder/#arg

After testing I have seen the secrets shown in the Logs in the Azure portal. These are secrets that viewers of the logs should not see. This came up as I used a `{` character in the secret value and that broke the script.

Contributor guide

Open the contributing guide

Research direction

Start at cmd/acb/commands/build/build.go around line 302 and compare the --secretBuildArgs mapping with Docker's ARG guidance. Reproduce the `{` case and inspect the resulting Azure portal logs; done means the expected secret-consumption behavior and log exposure are clearly documented or corrected, with the outcome verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cloud, devops, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.