Azure / Azure/acr-builder

Escape &,> in --set and --build-arg

Open
#329 1 comment 1 reaction 0 assignees View on GitHub
area/cli needs-discussion
Dominant language
Go
Stars
41
Forks
45
Avg merge
6h 52m
Merged PRs (30d)
5

Description

Feature Request: Escape the `&` `>` passed in `--build-arg` and `--set` options, eg

```
acb build --build-arg arg1=a&b => arg1=a\&b
acb exec --set key1=a>b => key1=a\>b
```

Maybe it's just safe to escape all chars passed in `--build-arg` and `--set`, eg `\a\r\g\1\=\a\&\b`

Contributor guide

Open the contributing guide

Research direction

Start by locating the argument parsing and handling for the `--build-arg` and `--set` options used by `acb build` and `acb exec`. Done means values containing `&` and `>` are escaped as shown; the broader question of whether all characters should be escaped remains part of the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.