Azure / Azure/WALinuxAgent

SUSE: sysconfig values may get clobbered

Open
#2,607 2 comments 0 reactions 1 assignee Claimed by @narrieta View on GitHub
Dominant language
Python
Stars
581
Forks
397
Avg merge
2d 15h
Merged PRs (30d)
9

Description

https://github.com/Azure/WALinuxAgent/blob/76f769cb53eced67609b3c2f9c758afc96be9934/azurelinuxagent/common/osutil/suse.py#L113

Looking at wicked's source, this is buggy. Wicked accepts values with single quotes, double quotes, and no quotes at all, so this code should be prepared to react to all those variants ("AUTO", 'AUTO', and AUTO) and not clobber them if the wrong quotes are used.

https://github.com/openSUSE/wicked/blob/a0ba667fd3101bea28c7b0bb3d8692accf6069ae/src/sysconfig.c#L313-L318

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.