Azure / Azure/ResourceModules

[Feature Request]: Align networkProfile implementation for VM and VMSS

Open
#2,500 1 comment 0 reactions 1 assignee Claimed by @rahalan View on GitHub
[cat] modules enhancement
Dominant language
PowerShell
Stars
737
Forks
436
Avg merge
10d 7h
Merged PRs (30d)
1

Description

### Description

VM and VMSS modules implement the `networkProfile` property differently. VM is setting `networkInterfaces` (Ref [here](https://github.com/Azure/ResourceModules/blob/main/modules/Microsoft.Compute/virtualMachines/deploy.bicep#L463)) while VMSS is setting `networkInterfaceConfigurations` (Ref [here](https://github.com/Azure/ResourceModules/blob/main/modules/Microsoft.Compute/virtualMachineScaleSets/deploy.bicep#L429)).

This issue is about aligning the implementation for the two modules.

As part of the alignment, we should also investigate on the warning thrown by the VM module using the resourceId function within its `networkProfile` implementation:

```
Warning use-resource-id-functions: If property "id" represents a resource ID, it must use a symbolic resource reference, be a parameter or start with one of these functions: extensionResourceId, guid, if, reference, resourceId, subscription, subscriptionResourceId, tenantResourceId. [https://aka.ms/bicep/linter/use-resource-id-functions]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.